Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: company tax setup in setup wizard #1510

Merged
merged 2 commits into from Dec 31, 2023
Merged

refactor: company tax setup in setup wizard #1510

merged 2 commits into from Dec 31, 2023

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Dec 30, 2023 •
edited

Fixes

  • Consistent allowed tax rates as string
  • Update Trigger event for company name as updated in ERPNext
  • Remove unnecessary stage for setting up tax template

@vorasmit vorasmit changed the title fix: enqueue company tax setup in setup wizard refactor: company tax setup in setup wizard Dec 31, 2023
@vorasmit vorasmit merged commit 7f5baa1 into resilient-tech:develop Dec 31, 2023
10 of 11 checks passed
@vorasmit vorasmit deleted the fix-setup branch December 31, 2023 12:34
mergify bot pushed a commit that referenced this pull request Dec 31, 2023
@vorasmit @mergify
refactor: company tax setup in setup wizard (#1510)
5c10828 
* fix: enqueue company tax setup in setup wizard

* fix: remove duplicate check after refactor

(cherry picked from commit 7f5baa1)
@mergify mergify bot mentioned this pull request Dec 31, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 31, 2023
@vorasmit @mergify
refactor: company tax setup in setup wizard (#1510)
b68c1e7 
* fix: enqueue company tax setup in setup wizard

* fix: remove duplicate check after refactor

(cherry picked from commit 7f5baa1)
@mergify mergify bot mentioned this pull request Dec 31, 2023
Merged
mergify bot added a commit that referenced this pull request Dec 31, 2023
@mergify
Merge pull request #1519 from resilient-tech/mergify/bp/version-15-ho…
948e790 
…tfix/pr-1510

refactor: company tax setup in setup wizard (backport #1510)
mergify bot added a commit that referenced this pull request Dec 31, 2023
@mergify
Merge pull request #1518 from resilient-tech/mergify/bp/version-14-ho…
a593732 
…tfix/pr-1510

refactor: company tax setup in setup wizard (backport #1510)
nabinhait pushed a commit to nabinhait/india-compliance that referenced this pull request Jan 15, 2024
@vorasmit @nabinhait
refactor: company tax setup in setup wizard (resilient-tech#1510)
80e4801 
* fix: enqueue company tax setup in setup wizard

* fix: remove duplicate check after refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljain112 ljain112 ljain112 left review comments

Assignees
No one assigned
Labels
backport version-14-hotfix backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vorasmit @ljain112